Skip to content

Conversation

@zhipeng93
Copy link
Contributor

@zhipeng93 zhipeng93 commented Sep 1, 2022

What is the purpose of the change

Add Transformer and Estimator for IDF in Flink ML.

Brief change log

  • Added java/python source/test/example for Transformer and Estimator for IDF in Flink ML.
  • The public interface is consistent with IDF in Spark ML.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (no)
  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (Java doc)

Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some comments as below.

@zhipeng93 zhipeng93 force-pushed the FLINK-28806 branch 3 times, most recently from 5784e0e to d1c391c Compare September 5, 2022 09:38
Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM.

@lindong28
Copy link
Member

Thanks for the PR! LGTM. Thanks @yunfengzhou-hub for the review.

@lindong28 lindong28 merged commit d224f56 into apache:master Sep 7, 2022
@zhipeng93 zhipeng93 deleted the FLINK-28806 branch September 7, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants