Skip to content

[FLINK-30014][hotfix] Ensure saving non-null value in aggregate util function state #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhipeng93 merged 1 commit into from
Nov 18, 2022
Merged

[FLINK-30014][hotfix] Ensure saving non-null value in aggregate util function state #177

zhipeng93 merged 1 commit into from
Nov 18, 2022

Conversation

@yunfengzhou-hub
Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub commented Nov 17, 2022 •
edited
Loading

What is the purpose of the change

This PR fixes the NPE that would possibly be thrown when using DataStreamUtils.aggregate.

Brief change log

  • Save only non-null values in the aggregate utility function's state.
  • Clarify the behavior of the aggregate utility function in respect of input parallelism and add a test for the corner case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@yunfengzhou-hub yunfengzhou-hub marked this pull request as ready for review November 17, 2022 10:05
@yunfengzhou-hub yunfengzhou-hub force-pushed the FLINK-30014 branch 2 times, most recently from 0dc6a27 to df5f886 Compare November 18, 2022 01:44
zhipeng93
zhipeng93 reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@zhipeng93 zhipeng93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Left two minor comments below.

@zhipeng93
Copy link
Contributor

zhipeng93 commented Nov 18, 2022

Thanks for the update. LGTM.

@zhipeng93 zhipeng93 changed the title [FLINK-30014][hotfix] ensure saving non-null value in aggregate util function state [FLINK-30014][hotfix] Ensure saving non-null value in aggregate util function state Nov 18, 2022
@zhipeng93 zhipeng93 merged commit bc24667 into apache:master Nov 18, 2022
Fanoid pushed a commit to Fanoid/flink-ml that referenced this pull request Apr 6, 2023
@yunfengzhou-hub @zhipeng93
[FLINK-30014][hotfix] Ensure saving non-null value in aggregate util …
4bd23ed 
…function state

This closes apache#177.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhipeng93 zhipeng93 zhipeng93 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yunfengzhou-hub @zhipeng93