[FLINK-29603] Add Transformer for StopWordsRemover #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
4 times, most recently
from
759d0af to
93b103f
Compare
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
2 times, most recently
from
074e565 to
038708e
Compare
jiangxin369
reviewed
Nov 30, 2022
Contributor
jiangxin369
left a comment
jiangxin369
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left some comments.
flink-ml-lib/src/main/resources/org/apache/flink/ml/feature/stopwords/README
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/stopwordsremover/StopWordsRemover.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
10 times, most recently
from
c11f88b to
1d36079
Compare
jiangxin369
reviewed
Dec 4, 2022
Contributor
jiangxin369
left a comment
jiangxin369
left a comment
There was a problem hiding this comment.
Thanks for the update, left some comments.
flink-ml-lib/src/main/resources/org/apache/flink/ml/feature/stopwords/README
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
4 times, most recently
from
2e97ccb to
18c39dd
Compare
jiangxin369
reviewed
Dec 7, 2022
Contributor
jiangxin369
left a comment
jiangxin369
left a comment
There was a problem hiding this comment.
@yunfengzhou-hub Thanks for the PR. LGRM overall. Only left a minor comment.
...-ml-lib/src/main/java/org/apache/flink/ml/feature/stopwordsremover/StopWordsRemoverBase.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
from
18c39dd to
704194a
Compare
lindong28
reviewed
Dec 9, 2022
...-ml-lib/src/main/java/org/apache/flink/ml/feature/stopwordsremover/StopWordsRemoverBase.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
from
704194a to
b295eef
Compare
yunfengzhou-hub
force-pushed
the
FLINK-29603
branch
from
b295eef to
c07b600
Compare
Member
|
Thanks for the PR. And thanks @jiangxin369 for the review. LGTM. |
Fanoid
pushed a commit
to Fanoid/flink-ml
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds the Transformer of stop words remover algorithm.
Brief change log
latestto20.04due to this.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation