-
Notifications
You must be signed in to change notification settings - Fork 90
[FLINK-30348] Add HasSeed param for RandomSplitter #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @weibozhao, The failure thrown in the CI of this PR has been fixed by a recently merged PR. Could you please rebase this PR onto the latest master code to ensure the tests can pass? |
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Left some comments as below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/randomsplitter/RandomSplitter.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/RandomSplitterTest.java
Outdated
Show resolved
Hide resolved
cfae6c6 to
7016905
Compare
|
Hi @weibozhao, thanks for the update. Could you please modify the description section of this PR and its corresponding Jira ticket, explaining the changes made in this PR and why we should add them to Flink ML? |
I have modified the description of this PR. |
|
@weibozhao Thanks for the update :) Can you also update the PR title as well as the commit message to make it more informative? (e.g., |
|
OK |
done. |
What is the purpose of the change
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation