Skip to content

Conversation

@zhipeng93
Copy link
Contributor

@zhipeng93 zhipeng93 commented Feb 22, 2023

What is the purpose of the change

This PR fixes several iteration bugs.

Brief change log

  • Restrict that TailOperator should only have one input since it does not align the epoch watermarks.
  • Fix wrong typeinfo in ProxyOperatorStateBackend.
  • Added unit test to verify the above changes.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zhipeng93 zhipeng93 marked this pull request as draft February 22, 2023 13:13
@zhipeng93 zhipeng93 marked this pull request as ready for review February 23, 2023 04:18
@zhipeng93
Copy link
Contributor Author

@gaoyunhaii Can you help to review this PR?

Copy link
Member

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some comments below.

@zhipeng93 zhipeng93 force-pushed the FLINK-31173 branch 5 times, most recently from 0d9a9af to 251917e Compare April 19, 2023 01:46
@lindong28 lindong28 changed the title [Flink-31173] Fix serveral iteration bugs [FLINK-31173] Fix serveral iteration bugs Apr 19, 2023
@zhipeng93 zhipeng93 force-pushed the FLINK-31173 branch 3 times, most recently from 255538a to 3add4ea Compare April 20, 2023 06:05
@lindong28
Copy link
Member

Thanks for the update. LGTM.

@lindong28 lindong28 closed this in 0c852da Apr 20, 2023
lindong28 pushed a commit that referenced this pull request Apr 20, 2023
zhipeng93 added a commit to zhipeng93/flink-ml that referenced this pull request Apr 21, 2023
zhipeng93 added a commit to zhipeng93/flink-ml that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants