Skip to content

Conversation

@jiangxin369
Copy link
Contributor

@jiangxin369 jiangxin369 commented Mar 16, 2023

What is the purpose of the change

Obtains the KeySelector with UserClassLoader instead of AppClassLoader to fix FLINK-31486.

Brief change log

  • Obtains the KeySelector with UserClassLoader.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@jiangxin369 jiangxin369 marked this pull request as draft March 16, 2023 12:42
@jiangxin369 jiangxin369 marked this pull request as ready for review March 17, 2023 08:46
@jiangxin369
Copy link
Contributor Author

@gaoyunhaii @lindong28 Could you help review this PR?

@lindong28
Copy link
Member

Thanks for the PR. Can you add a unit test to cover the bug fixed by this PR?

@jiangxin369
Copy link
Contributor Author

@lindong28 I wanted to add a unittest for the change, but I cannot reproduce the exception within a minicluster and then fix it. The reason is the user codes are also added to the java classpath of the unittest process and can also be loaded by AppClassLoader.

@lindong28
Copy link
Member

Thanks for the PR! LGTM.

@lindong28 lindong28 merged commit fa5f47e into apache:master Mar 21, 2023
Fanoid pushed a commit to Fanoid/flink-ml that referenced this pull request Apr 6, 2023
zhipeng93 pushed a commit to zhipeng93/flink-ml that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants