[FLINK-25616] Add Transformer for VectorAssembler #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weibozhao
force-pushed
the
FLINK-25616
branch
3 times, most recently
from
77b1032 to
00b8bcc
Compare
Contributor
Author
|
@zhipeng93 @lindong28 @gaoyunhaii Can you help review this PR? |
Member
|
Thanks for the PR. Before we continue to add more and more algorithm, what's our plan to make sure these algorithm's implementation could meet our performance target? I am concerned that if we add more algorithms before we have a benchmark plan, we might end up refactoring added algorithms in a unnecessary manner, which is probably not a good long term solution. |
weibozhao
force-pushed
the
FLINK-25616
branch
from
00b8bcc to
48251a4
Compare
Contributor
Author
|
I get your idea |
lindong28
changed the title
weibozhao
force-pushed
the
FLINK-25616
branch
8 times, most recently
from
dcdda92 to
5e1c68b
Compare
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the PR. Generally LGTM. Left some comments as below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Outdated
Show resolved
Hide resolved
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Left one comment as below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
weibozhao
force-pushed
the
FLINK-25616
branch
2 times, most recently
from
070edf9 to
bcae420
Compare
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the update. Left some comments as below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Outdated
Show resolved
Hide resolved
weibozhao
force-pushed
the
FLINK-25616
branch
3 times, most recently
from
8c959a5 to
b32f4d7
Compare
lindong28
reviewed
Apr 1, 2022
Member
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
Thanks for the update! Left some comments below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Outdated
Show resolved
Hide resolved
lindong28
reviewed
Apr 2, 2022
Member
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
Thanks for the update. Left some comments below.
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/VectorAssemblerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasHandleInvalid.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
weibozhao
force-pushed
the
FLINK-25616
branch
2 times, most recently
from
33ba886 to
4c1f152
Compare
weibozhao
force-pushed
the
FLINK-25616
branch
6 times, most recently
from
750e6b9 to
7add66f
Compare
lindong28
reviewed
Apr 2, 2022
Member
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
Thanks for the update! The PR looks pretty good now. Left just one minor comment.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add Transformer for VectorAssembler in FlinkML.
Brief change log
Add VectorAssembler.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @public(Evolving): (no)
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (Java doc)