Skip to content

[hotfix] Docs and typos #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aroch wants to merge 2 commits into from
Closed

[hotfix] Docs and typos #104

aroch wants to merge 2 commits into from

Conversation

@aroch
Copy link
Contributor

@aroch aroch commented Apr 30, 2020

  • Added step to 'Testing' section. If you run tests without installing dependencies first, it would fail.
  • Fixed typo in example code
  • Fixed typo in error message

igalshilman
igalshilman approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aroch!
LGTM!

@sjwiesman
Copy link
Contributor

sjwiesman commented Apr 30, 2020

Merging . . .

@sjwiesman sjwiesman closed this in bebf3d7 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aroch @sjwiesman @igalshilman