[FLINK-16311] [FLINK-16312] Fix PersistedAppendingBuffer contracts and HttpFunction.onAsyncResult #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzulitai
force-pushed
the
FLINK-16311
branch
from
1893e6e to
478f788
Compare
The previous contracts were not possible to be provided, since Flink ListState never returns null when retrieving the list, regardless of if the access was after a clear, or the list was actually just empty. This commit changes the contract of the view() method to always return non-null, and also disallow appending / update the buffer with null elements or lists.
The HttpFunction was relying on incorrect contracts promised by PersistedAppendingBuffer, causing it to endlessly resend 0-sized batch requests. This commit fixes that to rely on the revisited contracts.
tzulitai
force-pushed
the
FLINK-16311
branch
from
478f788 to
41b2643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous contracts for
PersistedAppendingBufferwere not possible to be provided, since FlinkListStatenever returnsnullwhen retrieving the list, regardless of if the access was after a clear, or the list was actually just empty.This PR changes the contract of the
view()method to always return non-null, and also disallow appending / update the buffer withnullelements or lists.Following that, since
HttpFunctionwas relying on the previous incorrect contracts, it had a problem of endlessly resend 0-sized batch requests.This PR fixes that as well by relying on the new contracts.