[FLINK-16415] [core] Add format versioning to YAML-ized modules #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JsonModuleFactory is a static factory that creates JsonModules based on the specified format version. We currently only have one version, 1.0, and one corresponding JsonModule, i.e. the JsonModule class. We need to further refactor Pointers and JsonModule in the future once we introduce more versions.
Contributor
Author
|
cc @igalshilman |
Contributor
Author
|
Thanks, merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a required
versionfield to YAML-ized modules.The starting format version will be
1.0, following the conventions of systems like docker-compose.The changelog commits should be self-explanatory on how this is implemented.
Note: From the looks of the code, the
PointersandJsonModuleclasses could use some refactoring, but we can revisit that once we introduce more format versions in the future.Verifying
The
JsonModuleTesthas been adapted to cover this change.Same for the E2E test - the
RoutableKafkaE2Euses a YAML module, so that is covered there as well.