Skip to content

Conversation

@tzulitai
Copy link
Contributor

We should be using the apache-release build profile defined in the Apache Parent POM, with one exclusion: do not run the source-release-assembly execution goal.

We have our own scripts to create the source release, which correctly excludes binaries from distribution tarball. That script can be found under tools/releasing/create_source_release.sh.


Verifying

Build the project using mvn clean install -Papache-release.
Under project-root/target/, you should not find any source release packages, only POM files.

@tzulitai
Copy link
Contributor Author

cc @rmetzger
This fixes the problem you found with RC4 of 2.0.0.

This does not require a cancellation of the current ongoing RC, because the artifacts in the new Maven repository for RC4 is still built with the same commit hash.

@tzulitai tzulitai requested a review from rmetzger March 31, 2020 07:47
@rmetzger
Copy link
Contributor

Thanks a lot for proposing this fix.
I guess we don't have this problem in apache/flink because we are not using the "apache-release" profile for building the releases there?

@tzulitai
Copy link
Contributor Author

tzulitai commented Mar 31, 2020

@rmetzger correct, Flink defines its own release profile, but as far as I can tell, it uses essentially the same plugins used as the apache-release profile, minus the source-release-assembly execution.

Stateful Functions' build is relatively simpler, so we decided to just reuse the apache-release profile.

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@tzulitai
Copy link
Contributor Author

Thanks for the review, merging this ...

@tzulitai tzulitai closed this in 689e0c0 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants