[FLINK-16899][example][py-k8s] Adjust module.yaml to reflect the service definition #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yaml The python worker's service is accessible via http://statefun-python:8000. This commit updates the endpoint definition in module.yaml to reflect that.
tzulitai
approved these changes
Mar 31, 2020
Contributor
tzulitai
left a comment
tzulitai
left a comment
There was a problem hiding this comment.
LGTM, +1. Merging this to master and release-2.0.
tzulitai
pushed a commit
that referenced
this pull request
Apr 1, 2020
….yaml The python worker's service is accessible via http://statefun-python:8000. This commit updates the endpoint definition in module.yaml to reflect that. This closes #86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the Python k8s example, in the following way:
The Python stateful function worker is accessible on
http://statefun-python:8000,as defined at
python-worker-service.yaml(at.metadata.name).Yet
module.yamlrefers to a different endpoint, this PR fixes it.