[FLINK-29070] Provide a option to force the removal of the normalize node when streaming read #273
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node when streaming read
LadyForest
reviewed
Aug 23, 2022
| return ChangelogMode.insertOnly(); | ||
| } else if (table instanceof ChangelogValueCountFileStoreTable) { | ||
| return ChangelogMode.all(); | ||
| } else if (table instanceof ChangelogWithKeyFileStoreTable) { |
Contributor
There was a problem hiding this comment.
Nit: in the long run, I think we can simplify the configuration to some extent, e.g., depend on ChangelogProducer
LadyForest
approved these changes
Aug 23, 2022
Contributor
LadyForest
left a comment
LadyForest
left a comment
There was a problem hiding this comment.
Thanks for the contribution, LGTM
JingsongLi
added a commit
that referenced
this pull request
Aug 23, 2022
…node when streaming read This closes #273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many jobs that do not require a downstream normalize node, and the key is that the node has a very large cost.
Introduce a option:
Whether to force the removal of the normalize node when streaming read. Note: This is dangerous and is likely to cause data errors if downstream is used to calculate aggregation.