Skip to content

[FLINK-29070] Provide a option to force the removal of the normalize node when streaming read #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 2 commits into from
Aug 23, 2022
Merged

[FLINK-29070] Provide a option to force the removal of the normalize node when streaming read #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0364255
[FLINK-29070] Provide a option to force the removal of the normalize …
JingsongLi Aug 23, 2022
bb701ca
fix
JingsongLi Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/layouts/shortcodes/generated/core_configuration.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@
<td><p>Enum</p></td>
<td>Specify the startup mode for log consumer.<br /><br />Possible values:<ul><li>"full": Perform a snapshot on the table upon first startup, and continue to read the latest changes.</li><li>"latest": Start from the latest.</li><li>"from-timestamp": Start from user-supplied timestamp.</li></ul></td>
</tr>
<tr>
<td><h5>log.scan.remove-normalize</h5></td>
<td style="word-wrap: break-word;">false</td>
<td>Boolean</td>
<td>Whether to force the removal of the normalize node when streaming read. Note: This is dangerous and is likely to cause data errors if downstream is used to calculate aggregation and the input is not complete changelog.</td>
</tr>
<tr>
<td><h5>log.scan.timestamp-millis</h5></td>
<td style="word-wrap: break-word;">(none)</td>
Expand Down
5 changes: 5 additions & 0 deletions ...nnector/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import static org.apache.flink.table.store.CoreOptions.CHANGELOG_PRODUCER;
import static org.apache.flink.table.store.CoreOptions.LOG_CHANGELOG_MODE;
import static org.apache.flink.table.store.CoreOptions.LOG_CONSISTENCY;
import static org.apache.flink.table.store.CoreOptions.LOG_SCAN_REMOVE_NORMALIZE;

/**
* Table source to create {@link FileStoreSource} under batch mode or change-tracking is disabled.
Expand Down Expand Up @@ -120,6 +121,10 @@ public ChangelogMode getChangelogMode() {
} else if (table instanceof ChangelogWithKeyFileStoreTable) {
Copy link
Contributor

@LadyForest LadyForest Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: in the long run, I think we can simplify the configuration to some extent, e.g., depend on ChangelogProducer

Configuration options = Configuration.fromMap(table.schema().options());

if (options.get(LOG_SCAN_REMOVE_NORMALIZE)) {
return ChangelogMode.all();
}

if (logStoreTableFactory == null
&& options.get(CHANGELOG_PRODUCER) != ChangelogProducer.NONE) {
return ChangelogMode.all();
Expand Down
9 changes: 9 additions & 0 deletions flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,15 @@ public class CoreOptions implements Serializable {
.defaultValue(LogChangelogMode.AUTO)
.withDescription("Specify the log changelog mode for table.");

public static final ConfigOption<Boolean> LOG_SCAN_REMOVE_NORMALIZE =
ConfigOptions.key("log.scan.remove-normalize")
.booleanType()
.defaultValue(false)
.withDescription(
"Whether to force the removal of the normalize node when streaming read."
+ " Note: This is dangerous and is likely to cause data errors if downstream"
+ " is used to calculate aggregation and the input is not complete changelog.");

public static final ConfigOption<String> LOG_KEY_FORMAT =
ConfigOptions.key("log.key.format")
.stringType()
Expand Down