[FLINK-17276][checkstyle] add definitions from Flink and enforce them#2
Merged
NicoK merged 1 commit intoapache:masterfrom Apr 21, 2020
Merged
[FLINK-17276][checkstyle] add definitions from Flink and enforce them#2NicoK merged 1 commit intoapache:masterfrom
NicoK merged 1 commit intoapache:masterfrom
Conversation
This was referenced Apr 20, 2020
|
👍 always good to have checkstyle enforced, no objections here as well. LGTM from my side. |
Contributor
|
What a nuisance. Sorry there was so much to clean up. :( +1 |
- minor changes to the checkstyle profile were needed to cope with the newer version we have here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is based on #1 and adds Flink's checkstyle configuration plus the appropriate changes to enforce it.
Next PR: #3
This change is