Skip to content

Conversation

@AHeise
Copy link
Contributor

@AHeise AHeise commented Oct 14, 2020

No description provided.

@morsapaes
Copy link
Contributor

Thanks, @AHeise . I haven't checked the blogpost yet, but please remove any files that are not .md (the blogpost itself) or image files.

Also, the website will be rebuilt by the committer merging the PR.

@AHeise
Copy link
Contributor Author

AHeise commented Oct 14, 2020

Thanks, @AHeise . I haven't checked the blogpost yet, but please remove any files that are not .md (the blogpost itself) or image files.

Also, the website will be rebuilt by the committer merging the PR.

Thanks @morsapaes for checking. The main commit contains only md and images. I can remove the second commit, but I assumed that I'd merge the PR, so I built it already. It should be ignored during review.

Copy link
Contributor

@morsapaes morsapaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure you follow the guidelines, even if you're the person merging it. 😉 Please remove the second commit.

Did a review that mostly includes some nitpicks and structure improvements, nothing major.

@AHeise AHeise force-pushed the asf-site branch 3 times, most recently from e669eb6 to 4621f78 Compare October 15, 2020 09:30
@morsapaes
Copy link
Contributor

Re-checked, looks good. 👍

@rmetzger
Copy link
Contributor

Thanks for the review. I'll merge this now.

@asfgit asfgit closed this in 47fbdee Oct 15, 2020
curcur pushed a commit to curcur/flink-web that referenced this pull request Apr 5, 2021
snuyanzin pushed a commit to snuyanzin/flink-web that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants