Skip to content

Conversation

@marcuswang6
Copy link
Contributor

The "教程" column on the Flink 中文网 currently has two "With Paimon(incubating) (formerly Flink Table Store)".

Therefore, I delete one for brevity.

Also, the current link is wrong and I correct it with this link "With Paimon(incubating) (formerly Flink Table Store)"

Signed-off-by: Waterkin <1055905911@qq.com>
@marcuswang6 marcuswang6 changed the title [docs] Delete repeated pages and revise paimon url [FLINK-34365] Delete repeated pages and revise paimon url Feb 5, 2024
@marcuswang6 marcuswang6 changed the title [FLINK-34365] Delete repeated pages and revise paimon url [FLINK-34365] Delete repeated pages in Chinese Flink website and correct the Paimon url Feb 5, 2024
Copy link

@wanglijie95 wanglijie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this PR. I left one minor comment, PTAL.

weight: 5
title: With Paimon(incubating) (formerly Flink Table Store)
bookHref: https://paimon.apache.org/docs/master/engines/flink/"
bookHref: https://paimon.apache.org/docs/master/engines/flink/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about change this to "https://paimon.apache.org/docs/master/engines/flink/" instead of https://paimon.apache.org/docs/master/engines/flink/ ?
which will be same as docs/content/getting-started/with-paimon-incubating.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I have addressed it. Please check it again. Thanks!

Signed-off-by: Waterkin <1055905911@qq.com>
@wanglijie95
Copy link

Thanks for update @Waterkin. Merged.

@wanglijie95 wanglijie95 merged commit ec2e5c2 into apache:asf-site Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants