Skip to content

Conversation

@zhuzhurk
Copy link
Contributor

@zhuzhurk zhuzhurk commented Nov 6, 2019

What is the purpose of the change

allVerticesInSameSlotSharingGroupByDefault is currently for internal use only.
It's better to not add it in ExecutionConfig which is for user configurations.
This PR is to move it from ExecutionConfig to StreamGraph.

Brief change log

  • Moved allVerticesInSameSlotSharingGroupByDefault from ExecutionConfig to StreamGraph
  • Adjusted its usages

Verifying this change

This change is already covered by existing tests, such as BatchExecutorTest and StreamingJobGraphGeneratorTest*.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…t setting from ExecutionConfig to StreamGraph
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8d20db4 (Wed Dec 04 15:03:09 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 6, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@zhuzhurk
Copy link
Contributor Author

zhuzhurk commented Nov 6, 2019

@flinkbot run travis

@zhuzhurk
Copy link
Contributor Author

zhuzhurk commented Nov 8, 2019

@zentol would you help to review this change?
Per the discussion here and here, it's better to move this config out from ExecutionConfig. And StreamGraph would be a better place for it.

@zentol zentol self-assigned this Nov 8, 2019
@zentol zentol merged commit 2125ea2 into apache:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants