[FLINK-14618] [Runtime/Coordination] Provide the required akka framesize in the oversized message exception

[jacobsevart]

What is the purpose of the change

To help users understand the Akka framesize they must configure to avoid the oversized message exception.

Brief change log

• Add the attempted RPC's actual size to the relevant exception.

Verifying this change

This change added tests and can be verified as follows:

• Additional assertions in AkkaRpcActorOversizedResponseMessageTest#testOverSizedResponseMsg{Sync,Async} verifying the presence of the oversized message's actual size.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): yes
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: don't know
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit afe4aa6 (Wed Apr 15 11:36:06 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• afe4aa6 : SUCCESS Build

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build

[StephanEwen]

Looks good, thanks, will merge that.

Out of curiosity: Can you share which RPC messages you encountered to be oversized?

[jacobsevart]

I'm not sure how to tell. It sometimes happens during startup when recovering from a large checkpoint, and we currently solve it by deleting the checkpoint.