-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-14903][table] Relax structured types constraints #10307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit be6f37a (Wed Dec 04 15:53:45 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dawidwys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some smaller nitpicking comments.
| lastPart(parts, 2), | ||
| lastPart(parts, 1), | ||
| lastPart(parts, 0)); | ||
| final String catPart = lastPart(parts, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this logic is duplicated in UnresolvedIdentifier.of. We could create the UnresolvedIdentifier as UnresolvedIdentifier.of(parts.toArray())
| } | ||
|
|
||
| public Builder setNullable(boolean isNullable) { | ||
| public Builder isNullable(boolean isNullable) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Personally I would not use is prefix for setters. I'd use this prefix only for getters. How about just nullable?
| final Optional<ObjectIdentifier> identifier = structuredType.getOptionalObjectIdentifier(); | ||
| final Optional<Class<?>> implementationClass = structuredType.getImplementationClass(); | ||
|
|
||
| final StructuredType.Builder builder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This is really nitpicking. How about extracting the instantiation of new builder and duplicating the attributes to separate methods. The visit method is already quite long.
|
Thanks for the feedback @dawidwys. Merging... |
What is the purpose of the change
In order to allow type extraction of structured types that are not registered in a catalog, we need to relax the structured type concept to "inline or anonymous structured types" that are not identified by an object identifier in a catalog but the fully qualified implementation class.
This PR also fixes issues with
UnresolvedIdentifierBrief change log
UnresolvedIdentifiereverywhereUnresolvedIdentifierObjectIdentifieroptional for anonymous structured typesVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation