Skip to content

Conversation

@spoon-lz
Copy link
Contributor

@spoon-lz spoon-lz commented Dec 3, 2019

What is the purpose of the change

Update string "chk-" to constant

Brief change log

N/A

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

N/A

Documentation

N/A

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 3, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit bc31a8e (Tue Dec 03 09:17:53 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 3, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@klion26
Copy link
Member

klion26 commented Dec 5, 2019

@spoon-lz thanks for your contribution

but

We usually don't accept code "simplifications" unless they have practical benefits like performance improvements on critical code paths.

please ref to [1][2] for more information
[1] #10319
[2] https://issues.apache.org/jira/browse/FLINK-14945

@klion26
Copy link
Member

klion26 commented Dec 5, 2019

and when contributing, we should avoid git-merge commit in history, will use git rebase

@spoon-lz spoon-lz closed this Dec 9, 2019
@spoon-lz spoon-lz deleted the lz-20191203-constant branch December 9, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants