Skip to content

Conversation

@wangxiyuan
Copy link
Contributor

What is the purpose of the change

Some math calculation result is different between x86 and aarch64 because of hardware optimizations.

For exmaple, the Math.exp(1)

on X86 is      2.718281828459045
on aarch64 is  2.7182818284590455 

Use StrictMath can keep the result the same.

Brief change log

Add a new exp functino to use StrictMath instead.

Verifying this change

This change is already covered by existing tests, such as testArithmeticFunctions.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@wangxiyuan
Copy link
Contributor Author

@StephanEwen, Hi, this is another place that impact flink-table-planner unit test. Please help review. Thank you very much.

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 5, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a697824 (Thu Dec 05 08:45:21 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 5, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@StephanEwen
Copy link
Contributor

Looks good to me, +1
Will merge once the CI builds are green.

@wangxiyuan
Copy link
Contributor Author

@StephanEwen Thank you :)

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 6, 2019
This ensures compatibility of results across processor architectures

This closes apache#10432
@asfgit asfgit closed this in 5545d8a Dec 6, 2019
@wangxiyuan wangxiyuan deleted the add_exp_function branch December 9, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants