-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-15099][runtime] (FLIP-27) Add Operator Coordinators and Events #10483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
82 changes: 82 additions & 0 deletions
82
flink-core/src/main/java/org/apache/flink/util/AutoContextClassLoader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.util; | ||
|
|
||
| /** | ||
| * Sets a context class loader in a "try-with-resources" pattern. | ||
| * | ||
| * <pre> | ||
| * {@code | ||
| * try (AutoContextClassLoader ignored = AutoContextClassLoader.of(classloader)) { | ||
| * // code that needs the context class loader | ||
| * } | ||
| * } | ||
| * </pre> | ||
| * | ||
| * <p>This is conceptually the same as the code below. | ||
|
|
||
| * <pre> | ||
| * {@code | ||
| * ClassLoader original = Thread.currentThread().getContextClassLoader(); | ||
| * Thread.currentThread().setContextClassLoader(classloader); | ||
| * try { | ||
| * // code that needs the context class loader | ||
| * } finally { | ||
| * Thread.currentThread().setContextClassLoader(original); | ||
| * } | ||
| * } | ||
| * </pre> | ||
| */ | ||
| public final class AutoContextClassLoader implements AutoCloseable { | ||
|
|
||
| /** | ||
| * Sets the context class loader to the given ClassLoader and returns a resource | ||
| * that sets it back to the current context ClassLoader when the resource is closed. | ||
| * | ||
| * <pre>{@code | ||
| * try (AutoContextClassLoader ignored = AutoContextClassLoader.of(classloader)) { | ||
| * // code that needs the context class loader | ||
| * } | ||
| * }</pre> | ||
| */ | ||
| public static AutoContextClassLoader of(ClassLoader cl) { | ||
| final Thread t = Thread.currentThread(); | ||
| final ClassLoader original = t.getContextClassLoader(); | ||
|
|
||
| t.setContextClassLoader(cl); | ||
|
|
||
| return new AutoContextClassLoader(t, original); | ||
| } | ||
|
|
||
| // ------------------------------------------------------------------------ | ||
|
|
||
| private final Thread thread; | ||
|
|
||
| private final ClassLoader originalContextClassLoader; | ||
|
|
||
| private AutoContextClassLoader(Thread thread, ClassLoader originalContextClassLoader) { | ||
| this.thread = thread; | ||
| this.originalContextClassLoader = originalContextClassLoader; | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| thread.setContextClassLoader(originalContextClassLoader); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
...in/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexCoordinatorContext.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.executiongraph; | ||
|
|
||
| import org.apache.flink.runtime.jobgraph.OperatorID; | ||
| import org.apache.flink.runtime.messages.Acknowledge; | ||
| import org.apache.flink.runtime.operators.coordination.OperatorCoordinator; | ||
| import org.apache.flink.runtime.operators.coordination.OperatorEvent; | ||
| import org.apache.flink.util.FlinkRuntimeException; | ||
| import org.apache.flink.util.SerializedValue; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| /** | ||
| * An implementation of the {@link OperatorCoordinator.Context} that delegates call to an | ||
| * {@link ExecutionJobVertex}. | ||
| */ | ||
| final class ExecutionJobVertexCoordinatorContext implements OperatorCoordinator.Context { | ||
|
|
||
| private final OperatorID operatorId; | ||
|
|
||
| private final ExecutionJobVertex jobVertex; | ||
|
|
||
| ExecutionJobVertexCoordinatorContext(OperatorID operatorId, ExecutionJobVertex jobVertex) { | ||
| this.operatorId = operatorId; | ||
| this.jobVertex = jobVertex; | ||
| } | ||
|
|
||
| @Override | ||
| public OperatorID getOperatorId() { | ||
| return operatorId; | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Acknowledge> sendEvent(OperatorEvent evt, int targetSubtask) { | ||
| final SerializedValue<OperatorEvent> serializedEvent; | ||
| try { | ||
| serializedEvent = new SerializedValue<>(evt); | ||
| } | ||
| catch (IOException e) { | ||
| // we do not expect that this exception is handled by the caller, so we make it | ||
| // unchecked so that it can bubble up | ||
| throw new FlinkRuntimeException("Cannot serialize operator event", e); | ||
| } | ||
|
|
||
| return getTaskExecution(targetSubtask).sendOperatorEvent(operatorId, serializedEvent); | ||
| } | ||
|
|
||
| @Override | ||
| public void failTask(int subtask, Throwable cause) { | ||
| final Execution taskExecution = getTaskExecution(subtask); | ||
| taskExecution.fail(cause); | ||
| } | ||
|
|
||
| @Override | ||
| public void failJob(Throwable cause) { | ||
| jobVertex.getGraph().failGlobal(cause); | ||
| } | ||
|
|
||
| private Execution getTaskExecution(int subtask) { | ||
| return jobVertex.getTaskVertices()[subtask].getCurrentExecutionAttempt(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate of
TemporaryClassLoaderContextThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would consolidate that in a separate commit. If that gets used beyond plugins, it should reside in a more "universal" package. The
AutoContextClassLoaderis a tad bit nicer, especially javadoc wise.