Skip to content

Conversation

@wsry
Copy link
Contributor

@wsry wsry commented Dec 19, 2019

What is the purpose of the change

This PR removes data compression for pipelined shuffle mode. The feature may be added in the future version of Flink if there is a better solution.

Brief change log

  • The code and document relevant to data compression for pipeline mode is removed.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a8a9d94 (Thu Dec 19 10:25:28 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@wsry wsry force-pushed the FLINK-15308-fix branch 2 times, most recently from c09e6a1 to a2c34a0 Compare December 19, 2019 10:28
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 19, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

*
* @return a retained copy of self with separate indexes
*/
public BufferConsumer copy() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also adjust the method description above.

Copy link
Contributor

@zhijiangW zhijiangW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @wsry!
Almost LGTM except for one tiny comment. In addition, can you add some messages in commit for the reason of removing pipelined compression?

@wsry
Copy link
Contributor Author

wsry commented Dec 20, 2019

Thanks for the review @zhijiangW . I have updated the PR.

Current shuffle data compression implementation for pipelined mode introduce several special case handling including an additional synchronization which can complicate the network stack. So we decide to remove data compression for pipelined shuffle in version release-1.10 and the feature may be added back if there is a better solution in the future.
@zhijiangW zhijiangW merged commit b87fc76 into apache:release-1.10 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants