Skip to content

Conversation

@libenchao
Copy link
Member

Brief change log

Fix ExecutionConfigTests.test_equals_and_hash. It fails when default parallelism is 12.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit df147dd (Sun Dec 29 10:39:44 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 29, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@libenchao Thanks a lot for the fixing. LGTM.
Merging...

hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Dec 29, 2019
…_equals_and_hash

The default parallelism used by local environments is calculated according to the available
processors. We should specify the parallelism explicitly to avoid test unstable.

This closes apache#10715.
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Dec 29, 2019
…_equals_and_hash

The default parallelism used by local environments is calculated according to the available
processors. We should specify the parallelism explicitly to avoid test unstable.

This closes apache#10715.
@hequn8128 hequn8128 closed this in 539e6a0 Dec 29, 2019
hequn8128 pushed a commit that referenced this pull request Dec 29, 2019
…_equals_and_hash

The default parallelism used by local environments is calculated according to the available
processors. We should specify the parallelism explicitly to avoid test unstable.

This closes #10715.
hequn8128 pushed a commit that referenced this pull request Dec 29, 2019
…_equals_and_hash

The default parallelism used by local environments is calculated according to the available
processors. We should specify the parallelism explicitly to avoid test unstable.

This closes #10715.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants