-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-15459] Drop vendor specific repos from parent pom.xml #10750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We no longer need builds for vendor specific repos as Flink no longer bundles Hadoop dependencies. Putting the dependencies on the classpath should be good enough.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a6b6ede (Thu Jan 02 14:19:01 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapr_setup docs still reference this profile; not sure whether they require significant changes. May not be that trivial due to the whole zookeeper thing.
|
I thought the vendor specific documentation has been removed with f6ce8dd. I assume that the |
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, I was checking it locally and I'm not on the latest master.
+1
|
Thanks for the review @zentol. Merging this PR now. |
What is the purpose of the change
We no longer need builds for vendor specific repos as Flink no longer
bundles Hadoop dependencies. Putting the dependencies on the classpath
should be good enough.
cc @zentol
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation