[FLINK-15684][docs][bp-1.10] Add taskmanager.memory.flink.size to common options#10918
[FLINK-15684][docs][bp-1.10] Add taskmanager.memory.flink.size to common options#10918dawidwys wants to merge 2 commits intoapache:release-1.10from
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d318d59 (Tue Jan 21 12:53:18 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for creating this PR @dawidwys. LGTM. +1 for merging after resolving the only comment.
| .withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a " | ||
| + "TaskExecutor consumes, consisting of Total Flink Memory (configured with " | ||
| + "'taskmanager.memory.flink.size'), JVM Metaspace, and JVM Overhead. On " | ||
| + "containerized setups, this should be set to the container memory." |
There was a problem hiding this comment.
I would put the reference to flink.size at the end of the description similar to what we are doing in the description of TOTAL_FLINK_MEMORY.
|
Closing it. Will backport manually after addressing comment. |
What is the purpose of the change
Add
taskmanager.memory.flink.sizeto common options.Backport of #10916
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation