Skip to content

[FLINK-15684][docs][bp-1.10] Add taskmanager.memory.flink.size to common options#10918

Closed
dawidwys wants to merge 2 commits intoapache:release-1.10from
dawidwys:flink-15684-bp
Closed

[FLINK-15684][docs][bp-1.10] Add taskmanager.memory.flink.size to common options#10918
dawidwys wants to merge 2 commits intoapache:release-1.10from
dawidwys:flink-15684-bp

Conversation

@dawidwys
Copy link
Contributor

What is the purpose of the change

Add taskmanager.memory.flink.size to common options.

Backport of #10916

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d318d59 (Tue Jan 21 12:53:18 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 21, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann tillrohrmann self-assigned this Jan 21, 2020
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @dawidwys. LGTM. +1 for merging after resolving the only comment.

Comment on lines +260 to +263
.withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a "
+ "TaskExecutor consumes, consisting of Total Flink Memory (configured with "
+ "'taskmanager.memory.flink.size'), JVM Metaspace, and JVM Overhead. On "
+ "containerized setups, this should be set to the container memory."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the reference to flink.size at the end of the description similar to what we are doing in the description of TOTAL_FLINK_MEMORY.

@dawidwys
Copy link
Contributor Author

Closing it. Will backport manually after addressing comment.

@dawidwys dawidwys closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants