Skip to content

Conversation

@azagrebin
Copy link
Contributor

What is the purpose of the change

RocksDB compaction filter is always enabled by default after #10866 and we deprecated its disabling. The docs should not refer to its enabling/disabling. The Chinese translation still has to be adjusted separately.

Brief change log

adjust state.md

Verifying this change

doc change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7ac3802 (Thu Jan 23 14:50:39 UTC 2020)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Member

@GJL GJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok. It's up to you whether you want to address my suggestions.

Updating the timestamp more often can improve cleanup speed
but it decreases compaction performance because it uses JNI call from native code.
If you enable the default background cleanup then this strategy will be activated for RocksDB backend and the current timestamp will be queried each time 1000 entries have been processed.
The default background cleanup for RocksDB backend queries the current timestamp each time when 1000 entries have been processed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo, "when" is not needed.

Maybe another alternative that sounds better to me: [...] queries the current timestamp for every 1000 processed entries

##### Cleanup during RocksDB compaction

If RocksDB state backend is used, another cleanup strategy is to activate Flink specific compaction filter.
If RocksDB state backend is used, another cleanup strategy is to call Flink specific compaction filter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it sounds like that the cleanup strategy won't be active by default or there are other strategies that can be used – Maybe that's just me. My proposal would be:

If the RocksDB state backend is used, a Flink specific compaction filter will be employed to enable background cleanup.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 23, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@azagrebin
Copy link
Contributor Author

Thanks for the review @GJL
I addressed the comments, merging this

@azagrebin
Copy link
Contributor Author

merge into master by 05bddfb
merge into 1.10 by 52a7ac9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants