-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-2493] Simplify names of example program JARs #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The implementation method may not be the best solution. Actually i tried a couple of solutions(for example:use finalName tag to replace classifier),but because there having many dependency with java examples internally, "rename depended Jars" would generate too much influence for other programs, so selecting such change has least influence on the system :) |
|
Looks nice. Can you help me quickly? I would like to understand why the internal maven dependencies on the Java examples have problems when you use the "finalName" classifier? |
|
@StephanEwen After using the tag of "finalName" to replace classifier, [ERROR] /Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:148: error: not found: value KMeansData |
|
Strange, the dependency here should not be dependent on the individual program jars, but on the aggregate Anyways, as long as your version works, let's use it :-) |
|
And when i worked the issue, i found that not only the three examples have dependency with flink-java-examples-0.10-SNAPSHOT.jar. Many other places also have dependency, for example: flink-staging/flink-fs-tests/src/test/java/org.apache.flink.tachyon/HDFSTest row 45-28:
|
|
@StephanEwen i found that many other documents(docs/apis\cli.md, examples.md etc) need update correspondingly, let me update it together, and update the commit. |
|
@chenliang613, thanks for the PR! |
The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples to incompatible versions of Flink
Propose to name the file examples/ConnectedComponents.jar rather than examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar.
The result as below:
build-target
--examples
--ConnectedComponents.jar
--EnumTrianglesBasic.jar
--EnumTrianglesOpt.jar
......