-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-15785][travis][e2e] Rework E2E test activations #10954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0a4cdba (Tue Jan 28 12:54:58 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
tillrohrmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @zentol. The changes look good to me. I tried the PR out and it seems to generate the right sets of inclusions/exclusions. I had 2 minor comments. +1 for merging them after resolving the comments.
| println "includes: " + project.properties.includeE2E | ||
| println "excludes: " + project.properties.excludeE2E |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep these printlns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I like that you can tell at a glance whether something is off, which will be useful on Travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe keep them for a bit until the transition to azure is done and we are confident it works as it should.
- consolidate travis activations in .travis.yml - introduce dedicated profile for each category to reduce verbosity - use gmavenplus-plugin to merge inclusion/exclusions across profiles - add java11 profile (i.e., don't rely on exclusion setup in root pom) - disable tests with Hadoop category by default - add Hadoop activations to e2e profiles
This PR reworks the activation logic for java end-to-end tests.
Introduces a new framework for specifying category inclusions/exclusions in
flink-end-to-end-tests, that is capable of automatically aggregating properties across profiles.Inclusions are defined by setting the
e2e.include.<category-class>, conversely exclusions by settinge2e.exclude.<category-class>. The value of the property is a boolean that controls whether the inclusion/exclusions is enabled or not.A groovy script searches for all properties matching the naming scheme, extracts the category class, aggregates inclusions/exclusions and sets the appropriate properties.
The script also prints the final inclusions/exclusions; I'd recommend trying it out and specifying different profile sets to see how it behaves.
Background: Maven does not really support combining categories. The surefire-plugin only accepts values like
catA,catB, instead of a list where individual items have their own XML element. This implies that in order to combine category definitions one would have to concatenate the current value with some other value, i.e., docategories = categories + "hello". Maven doesn't support this however since it is a recursive definition of a property.The following is a listing of every problem and how it was addressed:
They are now consolidated in .travis.yml. While this does introduce some redundancy it is still preferable because .travis.yml is the most visible travis file, and it is easier to mvoe the pre-commit activation around.
Each category now has their dedicated profile in
flink-end-to-end-teststhat set the appropriate category. This is significantly more concise and provides an abstraction of the specific categories used. (In other words, we can modify things at will without breaking setups)Now disabled by default.
Are now setup.
There is now a dedicated java11 profile in
flink-end-to-end-teststo ensure the java11 exclusions is always applied.