-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await #10970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d3bc38e (Thu Jan 30 06:45:30 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@flinkbot run travis |
tillrohrmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @wangyang0918. The change looks good. I had a single comment which I will address while merging this PR.
| final Duration timeout = TimeUtils.parseDuration( | ||
| flinkConfig.get(KubernetesConfigOptions.SERVICE_CREATE_TIMEOUT)); | ||
|
|
||
| return CompletableFuture.supplyAsync(() -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good enough to supply a SupplierWithException here via FunctionUtils.uncheckedSupplier().
…row a different one in ActionWatcher.await
d3bc38e to
f60216b
Compare
…row a different one in ActionWatcher.await This closes #10970.
…row a different one in ActionWatcher.await This closes apache#10970.
What is the purpose of the change
The ActionWatcher.await method should declare that it throws an InterruptedException instead of catching it, not resetting the interrupted flag and then throwing a different exception.
Brief change log
ActionWatcher.awaitVerifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation