Skip to content

[FLINK-15584] Give nested data type of ROWs in ValidationException. #10978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ayushtkn wants to merge 1 commit into from
Closed

[FLINK-15584] Give nested data type of ROWs in ValidationException. #10978

ayushtkn wants to merge 1 commit into from

Conversation

@ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Jan 30, 2020 •
edited
Loading

In

INSERT INTO baz_sink
SELECT
a,
ROW(b, c)
FROM foo_source

Schema mismatch mistakes will not get proper detail level, yielding the following:

Caused by: org.apache.flink.table.api.ValidationException: Field types of query result and registered TableSink [baz_sink] do not match.
Query result schema: [a: Integer, EXPR$2: Row]
TableSink schema: [a: Integer, payload: Row]

Leaving the user with an opaque 'Row' type to debug.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 30, 2020 •
edited
Loading

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit fea346b (Fri Feb 28 21:48:40 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 30, 2020 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@ayushtkn
Copy link
Member Author

ayushtkn commented Jan 31, 2020

@flinkbot run azure

@ayushtkn ayushtkn requested review from dawidwys and twalthr January 31, 2020 02:41
@ayushtkn ayushtkn changed the title [FLINK-15584] Give nested data type of ROWs in ValidationException [FLINK-15584] Give nested data type of ROWs in ValidationException. Jan 31, 2020
@ayushtkn ayushtkn requested review from hequn8128 and wuchong January 31, 2020 08:56
docete
docete reviewed Feb 6, 2020
View reviewed changes
Copy link
Contributor

@docete docete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ayushtkn Thanks for your PR and left some comments.

@docete
Copy link
Contributor

docete commented Feb 6, 2020

Please improve the PR naming and description so can be more easily and more thoroughly reviewed. See https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html

@ayushtkn
Copy link
Member Author

ayushtkn commented Feb 6, 2020

Thanx @docete for the review.
Made changes as suggested and added description.

@rmetzger
Copy link
Contributor

rmetzger commented Feb 26, 2020

@ayushtkn Can you rebase your change to the latest master? The test failures are caused by an issue that has been addressed by now.
Sorry for the inconvenience. We appreciate your contribution!

@ayushtkn
Copy link
Member Author

ayushtkn commented Feb 26, 2020

Thanx @rmetzger for the review.
I have rebased and pushed.

@rmetzger
Copy link
Contributor

rmetzger commented Feb 26, 2020

Okay, let's wait for the CI system to pick this up

@ayushtkn
Copy link
Member Author

ayushtkn commented Feb 27, 2020

Thanx @rmetzger
Seems the CI result is success.
can you give a check once

JingsongLi
JingsongLi approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayushtkn for your contribution, looks good to me.

...rc/test/scala/org/apache/flink/table/api/batch/sql/validation/InsertIntoValidationTest.scala

val sql = "INSERT INTO targetTable SELECT a, b FROM sourceTable"

util.tableEnv.sqlUpdate(sql)}
Copy link
Contributor

@JingsongLi JingsongLi Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, } should be new line. I will modify it before merge.

@JingsongLi
Copy link
Contributor

JingsongLi commented Mar 5, 2020

I will modify commit title to [FLINK-15584][table-planner] Give nested data type of ROWs in ValidationException, FYI. @ayushtkn

@JingsongLi
Copy link
Contributor

JingsongLi commented Mar 5, 2020

Merged in: 3408ead

@JingsongLi JingsongLi closed this Mar 5, 2020
@ayushtkn ayushtkn deleted the FLINK-15584 branch March 5, 2020 05:03
@rmetzger
Copy link
Contributor

rmetzger commented Mar 5, 2020

Thank you @JingsongLi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

@dawidwys dawidwys Awaiting requested review from dawidwys

@twalthr twalthr Awaiting requested review from twalthr

@hequn8128 hequn8128 Awaiting requested review from hequn8128

@wuchong wuchong Awaiting requested review from wuchong

+1 more reviewer

@docete docete docete left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component=TableSQL/LegacyPlanner review=description?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ayushtkn @flinkbot @docete @rmetzger @JingsongLi