Skip to content

[FLINK-16019][runtime] fix ContinuousFileReaderOperator error reporting #11071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FLINK-16019][runtime] fix ContinuousFileReaderOperator error reporting #11071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...in/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ public void dispose() throws Exception {
try {
cleanUp();
} catch (Exception ex) {
e = ExceptionUtils.firstOrSuppressed(ex, e);
e = ex;
}
}
{
Expand Down Expand Up @@ -442,7 +442,7 @@ private void cleanUp() {
try {
r.run();
} catch (Exception e) {
firstException = ExceptionUtils.firstOrSuppressed(firstException, e);
firstException = ExceptionUtils.firstOrSuppressed(e, firstException);
Copy link
Contributor

@pnowojski pnowojski Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some simple test for this bug?

Copy link
Contributor Author

@rkhachatryan rkhachatryan Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be reliable - the only difference will be in error message and stacktrace.

Copy link
Contributor

@pnowojski pnowojski Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only difference will be in error message and stacktrace.

Isn't that's the whole point of using firstOrSuppressed - to have the correct exception message?

Copy link
Contributor Author

@rkhachatryan rkhachatryan Feb 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can have 100% coverage.
Here the fix is trivial, it's check is trivial, the importance is low, the test is relatively difficult (operator init with all the Task required) and un-reliable.

(also the edit above IMO shouldn't be covered)

Copy link
Contributor

@pnowojski pnowojski Feb 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential test doesn't look difficult:

@Test(expected = ExpectedTestException.class)
public void test() throws Exception {
	// duplicated setup code
	TextInputFormat format = new TextInputFormat(new Path(testBasePath)) {
		@Override
		public void close() {
			throw new ExpectedTestException();
		}
	};
	// more duplicated code that could be deduplicated
	try (OneInputStreamOperatorTestHarness<TimestampedFileInputSplit, String> tester = ...) {
		tester.open();
	}
}

It's also reliable, assuming we get rid of the FlinkRuntimeException wrapping, which looks unnecessary.

That's ~10 lines of simple code after deduplication?

Copy link
Contributor Author

@rkhachatryan rkhachatryan Feb 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires some more configuration like time characteristic and types.
I'm not saying it's not possible or difficult, I'm just saying it doesn't worth to have it.

}
}
currentSplit = null;
Expand Down