Skip to content

[FLINK-16049] Remove outdated "Best Practices" section from Application Development Section#11087

Closed
aljoscha wants to merge 1 commit intoapache:masterfrom
aljoscha:flink-doc-remove-best-practices
Closed

[FLINK-16049] Remove outdated "Best Practices" section from Application Development Section#11087
aljoscha wants to merge 1 commit intoapache:masterfrom
aljoscha:flink-doc-remove-best-practices

Conversation

@aljoscha
Copy link
Contributor

This is outlined in https://cwiki.apache.org/confluence/display/FLINK/FLIP-42%3A+Rework+Flink+Documentation.

The information is also available in other places in the documentation or simply not needed anymore.

@aljoscha aljoscha force-pushed the flink-doc-remove-best-practices branch from 0694af5 to 99b9985 Compare February 13, 2020 15:40
@aljoscha aljoscha changed the title [FLINK-16049] Remove outdated "Best Pracatices" section from Application Development Section [FLINK-16049] Remove outdated "Best Practices" section from Application Development Section Feb 13, 2020
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 99b9985 (Thu Feb 13 15:42:47 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@knaufk knaufk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think, these best practices are either outdated or not relevant enough to have their own page.

The logback/log4j/log4j2 topic deserves some place in the documentation in Deployment->Metrics & Logging.

@StephanEwen
Copy link
Contributor

+1

This is super outdated.
Please merge this also for the release-1.10 branch.

@aljoscha
Copy link
Contributor Author

Done, thanks for the timely review! I also merged on release-1.10.

@aljoscha aljoscha closed this Feb 17, 2020
@aljoscha aljoscha deleted the flink-doc-remove-best-practices branch June 10, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants