Skip to content

[FLINK-16053][python] Remove redundant metrics in PyFlink#11089

Merged
dianfu merged 1 commit intoapache:masterfrom
dianfu:FLINK-16053
Feb 14, 2020
Merged

[FLINK-16053][python] Remove redundant metrics in PyFlink#11089
dianfu merged 1 commit intoapache:masterfrom
dianfu:FLINK-16053

Conversation

@dianfu
Copy link
Copy Markdown
Contributor

@dianfu dianfu commented Feb 14, 2020

What is the purpose of the change

We have recorded the metrics about how many elements it has processed in Python UDF. This kind of information is not necessary as there is also this kind of information in the Java operator. I have performed a simple test and find that removing it could improve the performance about 5% - 10%.

Brief change log

  • Removes redundant metrics in PyFlink

Verifying this change

This change is a performance improvement work and have verified in my local environment.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b48b577 (Fri Feb 14 07:50:41 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Feb 14, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@HuangXingBo
Copy link
Copy Markdown
Contributor

@dianfu Thanks a lot for the PR.
+1 from my side.

@dianfu
Copy link
Copy Markdown
Contributor Author

dianfu commented Feb 14, 2020

@HuangXingBo Thanks a lot for the review. Merging...

@dianfu dianfu merged commit 881a3ca into apache:master Feb 14, 2020
@dianfu dianfu deleted the FLINK-16053 branch June 10, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants