Skip to content

[FLINK-15652][kubernetes] Support for imagePullSecrets K8s option#11166

Closed
tisonkun wants to merge 2 commits intoapache:masterfrom
tisonkun:zhengcanbin-FLINK-15652
Closed

[FLINK-15652][kubernetes] Support for imagePullSecrets K8s option#11166
tisonkun wants to merge 2 commits intoapache:masterfrom
tisonkun:zhengcanbin-FLINK-15652

Conversation

@tisonkun
Copy link
Copy Markdown
Member

supersede #11054 .

close #11054 .

@flinkbot
Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2ffeee9 (Fri Feb 21 03:00:19 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Feb 21, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tisonkun tisonkun closed this in 7bc7930 Feb 21, 2020
@tisonkun tisonkun deleted the zhengcanbin-FLINK-15652 branch February 21, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants