Skip to content

Conversation

@KarmaGYZ
Copy link
Contributor

… env field

What is the purpose of the change

Remove redundant double-quote at the end of the env field, which cause mesos e2e test fail.

Brief change log

Remove redundant double-quote at the end of the env field.

Verifying this change

Trigger e2e test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@KarmaGYZ KarmaGYZ requested a review from zentol February 24, 2020 00:50
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 45a5042 (Fri Feb 28 21:47:52 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@KarmaGYZ
Copy link
Contributor Author

Travis link https://travis-ci.org/KarmaGYZ/flink/jobs/654212375.
I don't know why the "e2e - container - scala 2.12" keep failing because of timeout in "flink-connector-gcp-pubsub" and "flink-azure-fs-hadoop" module. But it seems not related to this PR.

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zentol zentol merged commit 127fd56 into apache:master Feb 24, 2020
@KarmaGYZ KarmaGYZ deleted the FLINK-16228 branch January 11, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants