[FLINK-16378][AZP] Disable Docker tests when running with JDK11 #11309
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 51918c2 (Wed Mar 04 12:44:10 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
|
||
| run_test "Heavy deployment end-to-end test" "$END_TO_END_DIR/test-scripts/test_heavy_deployment.sh" "skip_check_exceptions" | ||
|
|
||
| run_test "ConnectedComponents iterations with high parallelism end-to-end test" "$END_TO_END_DIR/test-scripts/test_high_parallelism_iterations.sh 25" |
There was a problem hiding this comment.
I would refrain from excluding this test until we have a confirmation that this is indeed java 11 related and some numbers of how reliably it fails.
There was a problem hiding this comment.
I can not remember having seen this failure on jdk8 ... In the last 48 hours, I have changed my policy to creating tickets for each test failure I see.
How many successful executions on master is proof enough that the test is stable on jdk8? (I propose 10)
How long should I keep the JIRA ticket open until we believe it is a jdk11 only issue? (I propose a week)
If we are not excluding this test for the JDK11 build, we won't have e2e coverage for jdk11 for everything that comes after.
There was a problem hiding this comment.
This test has always been incredibly flaky, that's why I advise against rash calls.
Trivial solution for preventing other tests from running in case of failures is to move it to the end of the script.
There was a problem hiding this comment.
naturally if you can show that it is reproducible on java 11 then we can of course disable it.
There was a problem hiding this comment.
Looks like I am able to fix the test on JDK11: https://issues.apache.org/jira/browse/FLINK-16417
| # - script: FLINK_DIR=build-target ./flink-end-to-end-tests/run-pre-commit-tests.sh | ||
| # displayName: Test - precommit | ||
| - script: FLINK_DIR=`pwd`/build-target flink-end-to-end-tests/run-nightly-tests.sh | ||
| - script: ${{parameters.environment}} FLINK_DIR=`pwd`/build-target flink-end-to-end-tests/run-nightly-tests.sh |
There was a problem hiding this comment.
should be a separate commit, and possibly even JIRA.
There was a problem hiding this comment.
Why?
What this does is passing the PROFILE variable to the script. This is necessary for deciding whether we are in a jdk11 setting or not. ... I see a clear relationship to the title of the JIRA I'm working on.
There was a problem hiding this comment.
because the script was already relying on this being set for the avro schema registry. This fixes a bug, it's not an improvement.
|
I addressed your comments:
|
|
Thank you for your review! |
3 participants
What is the purpose of the change
The docker tests are not passing on JDK11. Until this is implemented, we need to skip them
Brief change log
run-nightly-tests.shscript.Verifying this change
Set the
jdk: jdk11inazure-pipelines.ymland see the e2e tests passing