[FLINK-16524][python] Optimize the execution of Python UDF to use generator to eliminate unnecessary function calls #11374

HuangXingBo · 2020-03-11T07:59:06Z

What is the purpose of the change

This pull request will optimize the result of FlattenRowCoder and ArrowCoder to generator to eliminate unnecessary function calls

Brief change log

Add PassThroughLengthPrefixCoderImpl and PassThroughLengthPrefixCoder
Change the result of FlattenRowCoder and ArrowCoder to generator
Change the func of Operations to map

Verifying this change

This change added tests and can be verified as follows:

It is performance improvement feature, so current test is enough

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

How does this patch test

Test Code

@udf(input_types=[DataTypes.INT(False)], result_type=DataTypes.INT(False))
def inc(x):
    return x

t_env.register_function("inc", inc)

# num_rows = 100000000
num_rows = 100000
num_columns = 10

select_list = ["inc(c%s)" % i for i in range(num_columns)]
t_env.register_table_sink(
    "sink",
    PrintTableSink(
        ["c%s" % i for i in range(num_columns)],
        [DataTypes.INT(False)] * num_columns))

t_env.from_table_source(MultiRowColumnTableSource(num_rows, num_columns)) \
    .select(','.join(select_list)) \
    .insert_into("sink")

beg_time = time.time()
t_env.execute("perf_test")
print("consume time: " + str(time.time() - beg_time))

Test Results

num rows, num colums | Consume Time(Before) | Consume Time(After)
10kw,1 | 711s | 441s
10kw,10 | 1454s | 1221s

flinkbot · 2020-03-11T08:01:22Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9cb59ec (Wed Mar 11 08:01:22 UTC 2020)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-03-11T08:10:35Z

CI report:

944a7b2 Travis: SUCCESS Azure: PENDING

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

…wCoder to generator to eliminate unnecessary function calls

dianfu · 2020-03-13T02:32:45Z