[FLINK-16546][yarn] Fix logging bug in YarnClusterDescriptor#startAppMaster

[zhengcanbin]

What is the purpose of the change

It's a minor fixup of the warning log message in case of tmpJobGraphFile deletion failure.

From
LOG.warn("Fail to delete temporary file {}.", tmpConfigurationFile.toPath());
to
LOG.warn("Fail to delete temporary file {}.", tmpJobGraphFile.toPath());

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c119cb5 (Wed Mar 11 13:06:50 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• c119cb5 Travis: PENDING Azure: PENDING

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[XuQianJin-Stars]

+1 LGTM

[rmetzger]

It is pretty obvious that this error happened because the code has been copy-pasted from above.
Ideally, I would recommend to refactor this into one or more methods, then errors like this would not occur.

+1 to merge this.

[zhengcanbin]

It is pretty obvious that this error happened because the code has been copy-pasted from above.
Ideally, I would recommend to refactor this into one or more methods, then errors like this would not occur.

+1 to merge this.

Thanks for the review @XuQianJin-Stars, @rmetzger. How about adding a new utility method such as FileUtils#deleteFileOrDirectoryQuietly to delete the file or the directory quietly but log error message once an exception occurs.