[FLINK-16623]add the shorthand 'desc' for describe on sql client#11422
Merged
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit fba4e15 (Tue Mar 17 01:04:44 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
KurtYoung
reviewed
Mar 17, 2020
KurtYoung
left a comment
Contributor
There was a problem hiding this comment.
Could you add a test case to SqlCommandParserTest?
Contributor
Author
|
hi,@KurtYoung I add the test case on SqlCommandParserTest and submit the code |
KurtYoung
approved these changes
Mar 17, 2020
KurtYoung
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will merge this after travis.
Contributor
|
@flinkbot run travis |
liuzhixing1006
pushed a commit
to liuzhixing1006/flink
that referenced
this pull request
Mar 19, 2020
…l client This closes apache#11422
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add the shorthand 'desc' for describe on sql client
Brief change log
add the shorthand 'desc' for describe on sql client
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation