[FLINK-16690][task][tests] Refactor StreamTaskTest to reuse TestTaskBuilder and MockStreamTaskBuilder#11459
Merged
zhijiangW merged 3 commits intoapache:masterfrom Mar 21, 2020
Merged
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b9006b6 (Fri Mar 20 07:25:57 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
c33b0b2 to
9da7f28
Compare
pnowojski
approved these changes
Mar 20, 2020
Contributor
pnowojski
left a comment
There was a problem hiding this comment.
Nice changes :) LGTM % with green travis & azure
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/MockStreamTaskBuilder.java
Show resolved
Hide resolved
… and MockStreamTaskBuilder This closes apache#11459
zhijiangW
added a commit
that referenced
this pull request
Mar 21, 2020
zhijiangW
added a commit
that referenced
this pull request
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We can reuse existing
TestTaskBuilderandMockStreamTaskBuilderfor constructingTaskandStreamTaskeasily in tests to simplifyStreamTaskTestcase.Brief change log
see commit messages
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation