[FLINK-16753] Use CheckpointException to wrap exceptions thrown from AsyncCheckpointRunnable

[Jiayi-Liao]

What is the purpose of the change

If an exception is thrown from task's async checkpoint process, the checkpoint will be declined as expected, but the reason for declining checkpoint will be regarded as #CheckpointFailureReason.JOB_FAILURE, which gives a wrong message to users. We should replace #CheckpointFailureReason.JOB_FAILURE with #CheckpointFailureReason.EXCEPTION, otherwise user will see "The job has failed" on Checkpoint UI.

Brief change log

Use #CheckpointException to wrap the exception thrown from #AsyncCheckpointRunnable.

Verifying this change

A trival rework without testing.

Does this pull request potentially affect one of the following parts:

This change will correct the error message when circumstances mentioned above happen.

Documentation

No need.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8bcdb46 (Wed Mar 25 12:18:30 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 086b229 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[geektcp]

ok

[klion26]

Thanks for the contribution, the change LGTM, could you please update the commit message?

[Jiayi-Liao]

@klion26 Thanks for your review. The commit message is updated.

[zhijiangW]

Hi @Jiayi-Liao , can you rebase the codes based on the recent master? Then i can take over to further review it.
Sorry for pending this progress long time.

[Jiayi-Liao]

Hi @Jiayi-Liao , can you rebase the codes based on the recent master? Then i can take over to further review it.
Sorry for pending this progress long time.

@zhijiangW Thanks for the review. The rebase is done.

[Jiayi-Liao]

@zhijiangW The PR should be good now. Could you take another look?

[zhijiangW]

Thanks for the updates @Jiayi-Liao , LGTM!