Skip to content

Conversation

@rmetzger
Copy link
Contributor

What is the purpose of the change

We recently saw that e2e tests were timing out. This change increases the timeout by 20 minutes

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e53298d (Thu Mar 26 08:32:01 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@zentol
Copy link
Contributor

zentol commented Mar 26, 2020

Given that the bash tests haven't finished in the reported run, this implies that the java tests and potential log upload haven't run yet.

With this in mind, 20 minutes more seems a bit short.

@zentol zentol self-assigned this Mar 26, 2020
@rmetzger
Copy link
Contributor Author

The Java e2e tests run for ~4 minutes, the log upload is 10 seconds.
With the recent PR adding the missing profiles, the java e2e test don't consume much more.

But I'm happy to increase the time. 40 Minutes?

@zentol
Copy link
Contributor

zentol commented Mar 26, 2020

40 seems better, to give us a bigger buffer for newly added tests.

@rmetzger
Copy link
Contributor Author

Okay. Will update it to 40. Ok to merge?

@flinkbot
Copy link
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@rmetzger rmetzger closed this in e0517e0 Mar 26, 2020
@rmetzger
Copy link
Contributor Author

Thanks for your review!

KarmaGYZ pushed a commit to KarmaGYZ/flink that referenced this pull request Mar 31, 2020
KarmaGYZ pushed a commit to KarmaGYZ/flink that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants