Skip to content

[FLINK-16847][python] Support timestamp types in vectorized Python UDF #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hequn8128 merged 2 commits into from
Mar 31, 2020
Merged

[FLINK-16847][python] Support timestamp types in vectorized Python UDF #11556

hequn8128 merged 2 commits into from
Mar 31, 2020

Conversation

@dianfu
Copy link
Contributor

@dianfu dianfu commented Mar 29, 2020

What is the purpose of the change

This pull request adds support of LocalZonedTimestampType and TimestampType in vectorized Python UDF.

Brief change log

  • Add support of LocalZonedTimestampType in vectorized Python UDF
  • Add support of TimestampType in vectorized Python UDF

Verifying this change

This change added tests and can be verified as follows:

  • Java tests ArrowUtilsTest, BaseRowArrowReaderWriterTest and RowArrowReaderWriterTest.
  • Python tests test_pandas_udf.py

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5236963 (Sun Mar 29 06:00:43 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2020 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

hequn8128
hequn8128 reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianfu Thanks a lot for the PR. The code looks very good. Only a few suggestions below.

flink-python/pyflink/table/tests/test_pandas_udf.py
PyFlinkBlinkStreamTableTestCase):
pass

def test_data_types_only_supported_in_blink_planner(self):
Copy link
Contributor

@hequn8128 hequn8128 Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this test_data_types_only_supported_in_blink_planner into a class and make the BlinkStreamPandasUDFITTests and BlinkBatchPandasUDFITTests extending from this class.

Copy link
Contributor Author

@dianfu dianfu Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. +1

flink-python/pyflink/table/tests/test_pandas_udf.py Outdated
assert isinstance(timestamp_param[0], datetime.datetime), \
'timestamp_param of wrong type %s !' % type(timestamp_param[0])
assert timestamp_param[0] == timestamp_value, \
'timestamp_param is wrong value %s, %s!' % (timestamp_param[0], timestamp_value)
Copy link
Contributor

@hequn8128 hequn8128 Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "timestamp_param is wrong value %s, should be %s!"

flink-python/pyflink/table/types.py Outdated
return pa.time64('us')
else:
return pa.time64('ns')
elif type(data_type) == LocalZonedTimestampType or type(data_type) == TimestampType:
Copy link
Contributor

@hequn8128 hequn8128 Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe type(data_type) in [LocalZonedTimestampType, TimestampType]:

@dianfu dianfu force-pushed the pandas_types_timestamp branch from 5236963 to 475f1db Compare March 30, 2020 08:35
@dianfu
Copy link
Contributor Author

dianfu commented Mar 30, 2020

@hequn8128 Thanks a lot for the review. The comments make sense to me and have updated the PR according to the comments.

@hequn8128
Copy link
Contributor

hequn8128 commented Mar 30, 2020

@dianfu Thanks a lot for the update. LGTM. Merging...

@hequn8128 hequn8128 merged commit 851a830 into apache:master Mar 31, 2020
@dianfu dianfu deleted the pandas_types_timestamp branch June 10, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hequn8128 hequn8128 hequn8128 left review comments

Assignees

No one assigned

Labels

component=API/Python review=description?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dianfu @flinkbot @hequn8128 @rmetzger