Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Apr 3, 2020

Adds the REST API for managing cluster partitions. The collection of all cluster partitions belonging to a single data set is referred to as a "Cluster DataSet".

The API allows the user to list and delete partitions. The handlers are relatively straight-forward and pretty much just forward calls to the RM (which forwards them to the Tracker), at most converting some data-structures.

As a prerequisite we no longer filter incomplete data sets in PartitionTracker#listDataSets.
We don't have a mechanism to ensure that either all partitions of a data set are registered or the remaining partitions are released at some point.
In these cases the user has to step in, but without being able to list incomplete partitions there's nothing that can be done.
To differentiate between complete/incomplete partitions we expose the number of currently registered partitions.
This count is only determined when the listing is requested for performance and complexity reasons.

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 3, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 44066c5 (Fri Apr 03 10:45:56 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 3, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

zentol added 3 commits April 14, 2020 10:41
The name was misleading since the handler only interacts with the ResourceManager, and just happened to only be used by TaskExecutor-related handlers.
We don't have a mechanism to ensure that either all partitions of a data set are registered or the remaining partitions are released at some point.
In these cases the user has to step in, but without being able to list incomplete partitions there's nothing that can be done.
This commit relaxes the filtering, and introduces an additional optional count for the number of currently registered partitions.
This count is only determined when the listing is requested for performance and complexity reasons.
@zentol zentol merged commit 5da6ce8 into apache:master Apr 14, 2020
@zentol zentol deleted the 14504 branch April 16, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants