[FLINK-17152]fix wrong Aggfunction resultType and accType in FunctionDefinitionUtil

[zjuwangg]

What is the purpose of the change

• In FLINK-16414, I fixed the problem that using using udaf/udtf which doesn't implement getResultType, but also introduce this problem careless. This pr aims to solve aggregate function can not get correct return type.

Brief change log

• #9ed7dbb fix bug and add corresponding unit test.

Verifying this change

This change added tests and can be verified as follows:

• Added more unit tests in FunctionDefinitionUtilTest

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no )
• The runtime per-record code paths (performance sensitive): (no )
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9ed7dbb (Wed Apr 15 07:34:39 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[zjuwangg]

cc @KurtYoung @wuchong @bowenli86 to have a review when you are free. I think this bug should be in release 1.10.1 too.

[flinkbot]

CI report:

• 9ed7dbb Travis: SUCCESS Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[zjuwangg]

cc @JingsongLi to have a review too.

[wuchong]

Looks like this change is quite straightforward.

+1 to merge.

[zjuwangg]

Thanks @wuchong