Skip to content

[FLINK-17119][python] Add Cython support for composite types #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dianfu merged 2 commits into from
Apr 17, 2020
Merged

[FLINK-17119][python] Add Cython support for composite types #11767

dianfu merged 2 commits into from
Apr 17, 2020

Conversation

@HuangXingBo
Copy link
Contributor

@HuangXingBo HuangXingBo commented Apr 16, 2020

What is the purpose of the change

This pull request will support complex DataTypes in Cython

Brief change log

  • Add the cython implementation of complex DataTypes

Verifying this change

This change added tests and can be verified as follows:

  • Added ut test in test_fast_coders.py

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 16, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f59cc08 (Thu Apr 16 07:05:33 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 16, 2020 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@dianfu dianfu changed the title [FLINK-17119][python] Support Composite DataTypes in Cython [FLINK-17119][python] Add Cython support for composite types Apr 16, 2020
@dianfu dianfu self-assigned this Apr 16, 2020
dianfu
dianfu reviewed Apr 16, 2020
View reviewed changes
flink-python/pyflink/fn_execution/fast_coder_impl.pyx Outdated
else:
self._encode_byte(True)
self._encode_field(value_coder_type, value_type, value_coder, value)

Copy link
Contributor

@dianfu dianfu Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the empty line

flink-python/pyflink/fn_execution/fast_coder_impl.pxd Outdated
cdef class TimestampCoderImpl(BaseCoder):
cdef readonly bint is_compact

cdef class LocalZonedTimestampCoderImpl(BaseCoder):
Copy link
Contributor

@dianfu dianfu Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inherits TimestampCoderImpl?

flink-python/pyflink/fn_execution/fast_coder_impl.pyx
for i in range(self._output_field_count):
item = value[i]
if item is not None:
if self._output_coder_type[i] == SIMPLE:
Copy link
Contributor

@dianfu dianfu Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use _encode_field?

flink-python/pyflink/fn_execution/fast_coder_impl.pyx
self.row[i] = None
else:
if self._input_coder_type[i] == SIMPLE:
self.row[i] = self._decode_field_simple(self._input_field_type[i])
Copy link
Contributor

@dianfu dianfu Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use _decode_field

dianfu
dianfu approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@dianfu dianfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HuangXingBo
Copy link
Contributor Author

HuangXingBo commented Apr 17, 2020

Not sure why the tests have not been triggered by CiBot. The tests have passed in my personal travis: https://travis-ci.org/github/HuangXingBo/flink/builds/675692170

@dianfu
Copy link
Contributor

dianfu commented Apr 17, 2020

Thanks. Merging...

@dianfu dianfu merged commit 5eaf2b5 into apache:master Apr 17, 2020
@pnowojski
Copy link
Contributor

pnowojski commented Apr 17, 2020 •
edited
Loading

Guys, can you please pay attention to test failures? This failed in this PR:
https://dev.azure.com/rmetzger/Flink/_build/results?buildId=7591&view=logs&j=9cada3cb-c1d3-5621-16da-0f718fb86602&t=14487301-07d2-5d56-5690-6dfab9ffd4d9

https://issues.apache.org/jira/browse/FLINK-17205

I'm reverting this change CC @sunjincheng121

pnowojski added a commit that referenced this pull request Apr 17, 2020
@pnowojski
Revert "[FLINK-17119][python] Add Cython support for composite types (#…
c201e1d 
…11767)"

This reverts commit 5eaf2b5.
@sunjincheng121
Copy link
Member

sunjincheng121 commented Apr 17, 2020

Thanks @pnowojski

@dianfu
Copy link
Contributor

dianfu commented Apr 17, 2020

@pnowojski Sorry about this. The CiBot has not been triggered for about 10 hours after pushing a new commit. So just merge the PR when the tests passed in the personal travis. I'll pay more attention to this and will keep an eye on the tests both in travis and azure for the next time. Sorry about this again!

@pnowojski
Copy link
Contributor

pnowojski commented Apr 17, 2020 •
edited
Loading

Yes, we have some build queue issues, but that doesn't mean we should be ignoring CI. For couple of PRs that I was merging recently I had to wait before merging them. Also as far as I know there is a way to have a private azure setup similar to travis, maybe that would help in such situations. I'm fine with merging PRs if private azure/travis builds have passed. But not fine if just travis passed - travis is running way fewer tests.

@dianfu
Copy link
Contributor

dianfu commented Apr 17, 2020

@pnowojski Definitely agree with you. Thanks!

@HuangXingBo
Copy link
Contributor Author

HuangXingBo commented Apr 17, 2020

Currently, there is no gcc in azure which makes it impossible to run the cython tests in azure pipelines. I have created a JIRA https://issues.apache.org/jira/browse/FLINK-17212 to disable cython tests until flink-container install gcc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dianfu dianfu dianfu approved these changes

Assignees

@dianfu dianfu

Labels

component=API/Python review=description?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HuangXingBo @flinkbot @dianfu @pnowojski @sunjincheng121 @rmetzger