Skip to content

[FLINK-17068][python][tests] Ensure the permission of scripts set correctly before executing the Python tests#11805

Merged
dianfu merged 2 commits intoapache:masterfrom
dianfu:FLINK-17068
Apr 19, 2020
Merged

[FLINK-17068][python][tests] Ensure the permission of scripts set correctly before executing the Python tests#11805
dianfu merged 2 commits intoapache:masterfrom
dianfu:FLINK-17068

Conversation

@dianfu
Copy link
Copy Markdown
Contributor

@dianfu dianfu commented Apr 19, 2020

What is the purpose of the change

This pull request add the executable permission for the Python scripts before executing the Python tests.

Brief change log

  • Ensure the permission of scripts set correctly in dev/lint-python.sh

Verifying this change

Verify manually in my local environment.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2670def (Sun Apr 19 04:32:11 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 19, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge once the Azure tests have passed

@dianfu
Copy link
Copy Markdown
Contributor Author

dianfu commented Apr 19, 2020

@rmetzger Thanks a lot for the review. I will merge it once the tests passed.

…server.sh also depends on scripts such as config.sh
@dianfu dianfu merged commit 6e61339 into apache:master Apr 19, 2020
@dianfu dianfu deleted the FLINK-17068 branch June 10, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants