-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17239][docs] Streaming Analytics tutorial #11843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17239][docs] Streaming Analytics tutorial #11843
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5cdc506 (Tue Apr 21 11:56:54 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
NicoK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! +1 after addressing a few comments
| event to arrive happened at time 4, and it is followed by an event that happened earlier, at time 2, | ||
| and so on: | ||
|
|
||
| ··· 23 19 22 24 21 14 17 13 12 15 9 11 7 2 4 → |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, I would prefer to have this as a figure, or at least increase the font size and center it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it more presentable. (But I confess that the html I used isn't very pretty.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I would agree on that ;)
let me have a look at improving the html a bit...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to look nice (I'll apply it to your PR unless you object):
<div class="text-center" style="font-size: x-large; word-spacing: 0.5em; margin: 1em 0em;">
··· 23 19 22 24 21 14 17 13 12 15 9 11 7 2 4 →
</div>
Co-Authored-By: Nico Kruber <nico.kruber@gmail.com>
NicoK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'll rework the html a bit and will then merge
What is the purpose of the change
This tutorial introduces event time, watermarks, and windowing, in a somewhat basic way. concepts/timely-stream-processing needs to be reworked to fit better with this content, which is in FLINK-17247.
Brief change log
Adds a new tutorial and its figure.